How can we make Microsoft Teams better?

← Public

GitHub Enterprise Connection - GitHub profile pics are broken.

I use the GitHub Enterprise Connector, and it's pulling in things just fine. But profile pictures are broken. See the attached screenshot.

23 votes
Sign in
(thinking…)
Sign in with: Facebook Google
Forgot password?
Create a password
Signed in as (Sign out)
Close
Close

We’ll send you updates on this idea

Andy Mercer shared this idea  ·   ·  Flag idea as inappropriate…  ·  Admin →

11 comments

Sign in
(thinking…)
Sign in with: Facebook Google
Forgot password?
Create a password
Signed in as (Sign out)
Close
Close
Submitting...
An error occurred while saving the comment
  • Anonymous commented  ·   ·  Flag as inappropriate

    Also in title all ".", "-", "#", "(" and ")" (and maybe more) appear with an escape character "\"

    Example:
    Pull request assigned: "Item \#4711 \- Multiline Text Fields \(Backport\)"

  • Anonymous commented  ·   ·  Flag as inappropriate

    profile pic is included in the "sender" entity that's sent from github:
    "sender": {
    ...
    "avatar_url": "https://avatars.github.<corp_domain>/u/<id>?",
    ...
    }

    Seems to be a bug in the github enterprise connector.

    When looking at the icon in Teams with browser dev tools, the url is:
    https://urlp.asm.skype.com/v1/url/content?url=https%3a%2f%2favatars.github...
    which gives me "Authorization has been denied for this request." when called directly.

    So instead of calling the icon directly it tries to do some "Url scanning" that for some reason seems to fail.

    See https://skpy.t.allofti.me/protocol/other.html ("URL scanning")

  • Anonymous commented  ·   ·  Flag as inappropriate

    From what I see in github enterprise a very different payload is sent than what's displayed in MS Teams. So the github enterprise connector actually seems to reformat what it gets as webhook payload.

    Example for github (enterprise) payload: https://developer.github.com/webhooks/ ("Example delivery") --> you can also see what's beeing sent on the Settings / Hooks page in github enterprise (in case you have configured a webhook)

    Example for Teams MessageCard json: https://messagecardplayground.azurewebsites.net/ (select "GitHub - Issue opened")

  • Nitin Shinde commented  ·   ·  Flag as inappropriate

    Though the new GitHub Enterprise connector works, it has an issue. The message posted on a channel does not show the github avatar/profile pic of the user who trigger the commit/pull request etc.

  • Will Green commented  ·   ·  Flag as inappropriate

    Getting around this right now using Zapier, but it's super annoying.

    We know it's all webhook-based, just give us the directions on which webhooks to set up in our own Github instance.

  • Anonymous commented  ·   ·  Flag as inappropriate

    We need too. we using github alternatives called gitbucket. we hope that teams support for "GitHub unauthed mode" in Slack

  • Anonymous commented  ·   ·  Flag as inappropriate

    We need Github integration for our team to use Microsoft Teams effectively. There is integration for our existing Slack channel, so if you want to compete we need Github!

  • Brian commented  ·   ·  Flag as inappropriate

    This is very much needed. We have Github for Enterprise Slack integration that we use for our dev team to stay updated as to when new Pull Requests are in/comments on PR's/merged to master. Actually, this is so important that we're probably not going to leave Slack for MS Teams because of this.

  • Arturo Gutiérrez commented  ·   ·  Flag as inappropriate

    There is a connector for github.com only and there are many companies that are using github for enteprise on site, so could be possible add support for github enterprise in the connector too?

Forum Home

Reference Information for Teams

Public: Interoperability

Categories

Feedback and Knowledge Base

(thinking…)

More Teams Information